Support natural keys for the models #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for natural keys for the cookie and cookie group models. This required adding another unique constraint, this time to the cookie model. A specific cookie within a group was already looked up by name and domain in the existing code, so this DB constraint confirms the usage. Duplicate data would not have yielded the expected results, but users may not be aware of it, so this is also a breaking change. You can now dump and load fixtures for cookie consent, using these natural keys and avoid database primary key conflicts.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #122 +/- ##
==========================================
- Coverage 96.03% 90.09% -5.95%
==========================================
Files 11 11
Lines 404 414 +10
Branches 52 68 +16
==========================================
- Hits 388 373 -15
- Misses 11 36 +25
Partials 5 5 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #103
Added support for natural keys for the cookie and cookie group models. This required adding another unique constraint, this time to the cookie model. A specific cookie within a group was already looked up by name and domain in the existing code, so this DB constraint confirms the usage. Duplicate data would not have yielded the expected results, but users may not be aware of it, so this is also a breaking change.
You can now dump and load fixtures for cookie consent, using these natural keys and avoid database primary key conflicts.