Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add postgresql schema support. #507

Merged
merged 9 commits into from
Mar 6, 2024
Merged

Conversation

angryfoxx
Copy link
Contributor

@angryfoxx angryfoxx commented Jan 29, 2024

Description

Checklist

Please update this checklist as you complete each item:

  • Tests have been developed for bug fixes or new functionality.
  • The changelog has been updated, if necessary.
  • Documentation has been updated, if necessary.
  • GitHub Issues closed by this PR have been linked.

By submitting this pull request I agree that all contributions comply with this project's open source license(s).

@angryfoxx angryfoxx mentioned this pull request Jan 29, 2024
1 task
@angryfoxx
Copy link
Contributor Author

angryfoxx commented Jan 29, 2024

I am not sure that should I update the changelog. @Archmonger what do you think ?

@Archmonger
Copy link
Contributor

Yes. Since this is a feature change, you'll need a changelog bullet point.

docs/databases.rst Outdated Show resolved Hide resolved
dbbackup/tests/commands/test_dbrestore.py Outdated Show resolved Hide resolved
@Archmonger Archmonger marked this pull request as draft January 29, 2024 23:10
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.40%. Comparing base (6c11a67) to head (9d8f155).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #507      +/-   ##
==========================================
+ Coverage   91.23%   91.40%   +0.17%     
==========================================
  Files          19       19              
  Lines         856      873      +17     
  Branches      150      157       +7     
==========================================
+ Hits          781      798      +17     
  Misses         40       40              
  Partials       35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@angryfoxx angryfoxx marked this pull request as ready for review January 30, 2024 08:36
dbbackup/db/postgresql.py Outdated Show resolved Hide resolved
dbbackup/management/commands/dbbackup.py Outdated Show resolved Hide resolved
docs/changelog.rst Outdated Show resolved Hide resolved
@Archmonger
Copy link
Contributor

Archmonger commented Jan 30, 2024

This can be merged after handling the two remaining comments.

EDIT: Actually there are four coverage hits that should be fixed first. See above.

@angryfoxx
Copy link
Contributor Author

This can be merged after handling the two remaining comments.

EDIT: Actually there are four coverage hits that should be fixed first. See above.

@Archmonger The Schemas only available for Postgres so. I need to patch the database settings while testing. But I failed, could you give an example of how to do it

@Archmonger
Copy link
Contributor

Are you referring to the settings.py values? If so, this PR shows a good example of how to do that via @patch

@angryfoxx angryfoxx requested a review from Archmonger February 10, 2024 16:31
@angryfoxx
Copy link
Contributor Author

Hi @Archmonger, Could you review it again? I have created schema test for dbrestore just before and I think everything looks good.

Copy link
Contributor

@Archmonger Archmonger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Archmonger Archmonger merged commit 87952dc into jazzband:master Mar 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants