-
-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add postgresql schema support. #507
Conversation
I am not sure that should I update the changelog. @Archmonger what do you think ? |
Yes. Since this is a feature change, you'll need a changelog bullet point. |
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #507 +/- ##
==========================================
+ Coverage 91.23% 91.40% +0.17%
==========================================
Files 19 19
Lines 856 873 +17
Branches 150 157 +7
==========================================
+ Hits 781 798 +17
Misses 40 40
Partials 35 35 ☔ View full report in Codecov by Sentry. |
This can be merged after handling the two remaining comments. EDIT: Actually there are four coverage hits that should be fixed first. See above. |
@Archmonger The Schemas only available for Postgres so. I need to patch the database settings while testing. But I failed, could you give an example of how to do it |
Are you referring to the settings.py values? If so, this PR shows a good example of how to do that via |
Hi @Archmonger, Could you review it again? I have created schema test for dbrestore just before and I think everything looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Description
Checklist
Please update this checklist as you complete each item:
By submitting this pull request I agree that all contributions comply with this project's open source license(s).