Update models.py to retrieve app_label from model meta if no app is specified #1448
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retrieve app_label from model meta if no app is specified
meta_fields["app_label"] = self.app if self.app else model._meta.app_label
replaces
To ensure that the simple history model always has an app_label
Motivation and Context
I ran into this issue when developing an app for django that had an extra service that could integrate with any app, my service adds models into the app, and the models' histories are tracked using django simple history. Django threw the
Model class doesn't declare an explicit app_label and isn't in an application in INSTALLED_APPS.
which prompted me to go down this road.How Has This Been Tested?
This has only been tested in so far as it adds an app_label to models outside of an installed app. No official tests have been written.
Types of changes
Checklist:
pre-commit run
command to format and lint.AUTHORS.rst
CHANGES.rst