Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Django 5.0 support #519

Merged
merged 1 commit into from
Nov 9, 2024
Merged

Add Django 5.0 support #519

merged 1 commit into from
Nov 9, 2024

Conversation

ulgens
Copy link
Member

@ulgens ulgens commented Nov 9, 2024

No description provided.

@cclauss
Copy link
Contributor

cclauss commented Nov 9, 2024

Why not dj5.1 too?

Copy link
Contributor

@dancergraham dancergraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I would add Django 5.1 at the same time as it is the currently supported version and the tests pass fine but 5.0 is better than 4.1. I would also remove 3.2, 4.0 and 4.1 as they are no longer supported
https://www.djangoproject.com/download/#supported-versions

@dancergraham
Copy link
Contributor

suggestion: add a comment linking to the supported versions table to help with future updates
https://www.djangoproject.com/download/#supported-versions

@cclauss
Copy link
Contributor

cclauss commented Nov 9, 2024

As discussed in #516, we should keep adding support and removing support in two different pull requests. Adding support is easy but removing support should be done on a serious version change so we do not break apps that use this software.

I prefer this URL for explaining the matrix of support:

@dancergraham
Copy link
Contributor

I prefer this URL for explaining the matrix of support:

ahh yes much better - that explains the matrix between python and Django versions !

@ulgens
Copy link
Member Author

ulgens commented Nov 9, 2024

Why not dj5.1 too?

I was trying to handle each version by their own PR; otherwise, the project's history would become too complicated and not useful for further contributions.

Looks good - I would add Django 5.1 at the same time as it is the currently supported version and the tests pass fine but 5.0 is better than 4.1. I would also remove 3.2, 4.0 and 4.1 as they are no longer supported

Same reasoning here 🌷

The test matrix will get simplified when we start removing EOL versions.

@dancergraham
Copy link
Contributor

I was trying to handle each version by their own PR; otherwise, the project's history would become too complicated and not useful for further contributions.

Maybe separate commits with thematically grouped PRs would be my preferred balance between time spent writing and reviewing minor updates but I'm fine with this approach too.

@dancergraham dancergraham merged commit a53e2cd into master Nov 9, 2024
10 checks passed
@dancergraham dancergraham deleted the django5.0 branch November 9, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants