Add Django 5.0 support #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamchainz
force-pushed
the
django_5.0
branch
from
95950a1 to
0af39ab
Compare
adamchainz
commented
Oct 25, 2023
Comment on lines
+13
to
+24
| python-version: | ||
| - '3.8' | ||
| - '3.9' | ||
| - '3.10' | ||
| - '3.11' | ||
| - '3.12' | ||
| - 'pypy-3.10' | ||
| django-version: | ||
| - '3.2' | ||
| - '4.1' | ||
| - '4.2' | ||
| - '5.0' |
There was a problem hiding this comment.
breaking out like this reduces diff noise
Django 2.2 and 4.0 were left on the grid accidentally since d5ad2ac removed support. I dropped them, and the below exclude rules relating to them.
Codecov Report
@@ Coverage Diff @@
## master #139 +/- ##
=======================================
Coverage 89.85% 89.85%
=======================================
Files 2 2
Lines 138 138
Branches 48 48
=======================================
Hits 124 124
Misses 9 9
Partials 5 5 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
adamchainz
force-pushed
the
django_5.0
branch
from
0af39ab to
1a41709
Compare
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied what to change from #127.
I found no new warnings when running locally.