Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed distutils fallback #358

Merged
merged 1 commit into from
Mar 17, 2019
Merged

Conversation

claudep
Copy link
Contributor

@claudep claudep commented Mar 9, 2019

Copy link

@chfw chfw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if on some Linux distribution, setup tools is missing? On my project, someone proposed the opposite.

@claudep
Copy link
Contributor Author

claudep commented Mar 9, 2019

Then you won't be able to install this package anyway as several of its dependencies are also directly importing setuptools.setup without fallback. I think the time caring for a missing setuptools package is over now.

@chfw
Copy link

chfw commented Mar 9, 2019

Here's the reference to the issue: moremoban/pypi-mobans#66.

The main concern is for embedded device environment and docker builds where size matters.

@claudep
Copy link
Contributor Author

claudep commented Mar 9, 2019

I see, however I'm afraid unless a PEP changes that, the current good practice is still to directly import setuptools.setup.
See https://docs.python.org/3/library/distutils.html which is some official endorsement of setuptools.

@chfw
Copy link

chfw commented Mar 9, 2019

Thanks for further elaboration and we now understand both sides of the opinion. I have no objections for the merge.

@timofurrer
Copy link
Member

Totally agree! Thanks 🎉

@timofurrer timofurrer merged commit 0937c9f into jazzband:master Mar 17, 2019
@claudep claudep deleted the byedistutils branch March 17, 2019 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants