Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refs #273 - Replaced vendored markup lib by dependency #360

Merged
merged 1 commit into from
Oct 3, 2019
Merged

Refs #273 - Replaced vendored markup lib by dependency #360

merged 1 commit into from
Oct 3, 2019

Conversation

claudep
Copy link
Contributor

@claudep claudep commented Mar 9, 2019

No description provided.

@jdufresne
Copy link
Member

The file NOTICE could be removed with this change

https://github.com/kennethreitz/tablib/blob/733d77ad1ed393869825f74803781d9b9873782e/NOTICE#L1-L6

@claudep
Copy link
Contributor Author

claudep commented Mar 9, 2019

Good catch!

@claudep claudep force-pushed the markup branch 2 times, most recently from 8810314 to 386d3b2 Compare March 9, 2019 19:49
@ParthS007
Copy link
Contributor

@claudep Can you please resolve conflicts. Thanks for the PR!

@claudep
Copy link
Contributor Author

claudep commented Mar 10, 2019

Sure, done.

@jayvdb
Copy link
Member

jayvdb commented Mar 12, 2019

I noticed the new repo for MarkupPy doesnt contain any code - tylerbakke/MarkupPy#3 , but I guess it wasnt being modified much anyway as it is a 1:1 replacement for the vendored code in tablib.

IMO tablib/compat.py and tablib/packages/__init__.py should still have imports in them, importing the external libraries, to avoid breaking the interface of compat which users may be relying on.

Also it would be good if the setup.py reference has the correct capitalisation, MarkupPy, but not important as most setup.py inspection tools now get the requirements from requirements.txt .

@claudep claudep merged commit 8cc024e into jazzband:master Oct 3, 2019
@claudep claudep deleted the markup branch October 3, 2019 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timofurrer timofurrer timofurrer approved these changes

@jdufresne jdufresne jdufresne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@claudep @jdufresne @ParthS007 @jayvdb @timofurrer