Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use statistics backport #362

Closed
wants to merge 1 commit into from
Closed

Conversation

jayvdb
Copy link
Member

@jayvdb jayvdb commented Mar 12, 2019

There is a de-vendoring process happening, https://github.com/kennethreitz/tablib/issues/273 , and then a new one appears in the latest release.

@claudep
Copy link
Contributor

claudep commented Mar 12, 2019

As for me, I wouldn't mind keeping this code for the remaining duration of Python 2 support, which shouldn't be too long anyway. A dependency for 8 lines of code is a bit overkill, but let the maintainers decide.

@jayvdb
Copy link
Member Author

jayvdb commented Mar 13, 2019

Well its a dependency only for people on Python 2, and it means this library is able to use anything from Python 3 statistics , and nobody can modify it - if there are bugs in it, they should be fixed elsewhere. That avoids the problems encountered with dbfpy, where there are local modifications.

Also the license is different, so vendoring it means this library needs to carry an additional license, which adds complexity to users who need to do license checks before using a library.

@timofurrer
Copy link
Member

Well, the question here is, if it's worth to use the backport just for statistics.median function?
The currently "vendored" statistics.py only contains the median() function - which is not even the exact same as in cpython master.

@claudep
Copy link
Contributor

claudep commented Oct 3, 2019

Let this small vendored code die with Python 2.

@claudep claudep closed this Oct 3, 2019
@hugovk hugovk mentioned this pull request Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants