-
-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Python 2 code #410
Remove Python 2 code #410
Conversation
Codecov Report
@@ Coverage Diff @@
## master #410 +/- ##
==========================================
+ Coverage 80.81% 88.17% +7.36%
==========================================
Files 22 24 +2
Lines 1647 2385 +738
==========================================
+ Hits 1331 2103 +772
+ Misses 316 282 -34
Continue to review full report at Codecov.
|
I don't care so much, but replacing |
Also added some more tests, and include tests in coverage: https://nedbatchelder.com/blog/201908/dont_omit_tests_from_coverage.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, nice progress for the coverage!
Some extra cleanup for #390.
if sys.version_info < (2, 4):
code--py3-plus
__getslice__
, deprecated since Python 2.0 and removed in 3