Forbid incorrect document start (---) #1333
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously documents like the following was simply ignored:
----
# foo
bar: bam
jbeder
requested changes
Dec 22, 2024
There was a problem hiding this comment.
I think there is a bug, but I don't think this is the correct fix - right now, the behavior is correct for the following cases:
$ echo '----' | ./util/parse
----
This correctly parses it as a single scalar node "----". I suspect this will be incorrect with your solution.
$ echo '----\nfoo: bar' | ./util/parse
yaml-cpp: error at line 2, column 4: illegal map value
This is your first test - it's properly marked as an error in the existing code, and I think it may switch to the wrong error in your code.
However:
$ echo '----\n# foo\nbaz: 1' | ./util/parse
----
This is your second test, and this is wrong, as you point out; it should be an error.
| @@ -1682,5 +1682,15 @@ TEST_F(HandlerSpecTest, Ex8_22_BlockCollectionNodes) { | |||
| EXPECT_CALL(handler, OnDocumentEnd()); | |||
| Parse(ex8_22); | |||
| } | |||
|
|
|||
| TEST_F(HandlerSpecTest, InvalidDocStart1) { | |||
There was a problem hiding this comment.
Please put these tests in parser_test.cpp - the spec tests are just for examples explicitly given in the spec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously documents like the following was simply ignored: