Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

options to change the default server urls #49

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Cyrille37
Copy link

Hi,

I just propose to permit the change of server urls, it's some times useful ;-)

The default behavior of the Provider does not change, just 2 new optional options.

The README talk about them :

$OpenStreetMapProvider = new \JBelien\OAuth2\Client\Provider\OpenStreetMap([
    'clientId'     => 'yourId',          // The client ID assigned to you by OpenStreetMap.org
    'clientSecret' => 'yourSecret',      // The client password assigned to you by OpenStreetMap.org
    'redirectUri'  => 'yourRedirectUri', // The return URL you specified for your app on OpenStreetMap.org
    'dev'          => false              // Whether to use the OpenStreetMap test environment at https://master.apis.dev.openstreetmap.org/
    /*
    For a particular need you can change the default server urls with this two options:
    'osm_base_url' =>  'https://www.openstreetmap.org',
    'osm_base_url_dev' => 'https://master.apis.dev.openstreetmap.org',
    */
]);

Thanks and cheers :-)

@jbelien jbelien added the enhancement New feature or request label May 25, 2024
@Cyrille37
Copy link
Author

Hi @jbelien
Thanks you for having a look at this PR. Don't hesitate to ask me for corrections and improvements ;-)

@Cyrille37
Copy link
Author

Hi @jbelien
Will you accept this PR ? Any requirement ?
Thanks & cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants