Generic Importer: Respect tolerance during balancing #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Account for rounding errors by adding Expenses:FIXME posting only when the amount is smaller then the deduced/configured tolerance. Without this change the added test case would have received a posting "Expenses:FIXME 0.000100 USD".
Entries with postings with an unspecified amount caused an exception during balancing. Now they are simply considered already balanced.
|
Running into this as well (particularly for stock transactions). Is the merge just blocking for tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Account for rounding errors by adding Expenses:FIXME posting only when the amount is smaller then the deduced/configured tolerance.
Without this change the added test case would have received a posting
Expenses:FIXME 0.000100 USD.