ofx: support non-sale transfers out #98
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works with transactions like a charitable donation or a brokerage transfer which don't involve liquidating the asset that is being transferred out.
|
Thanks. Can you by any chance add a test case for this? |
|
@FiloSottile, I can add the test case if you can provide me with a sample block of OFX with the relevant case and the expected output. |
|
It looks like this PR and #55 make overlapping and conflicting assumptions about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works with transactions like a charitable donation or a brokerage
transfer which don't involve liquidating the asset that is being transferred out.