Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set TargetFrameworks solely to "netstandard2.0" #139

Closed
wants to merge 1 commit into from

Conversation

marco-carvalho
Copy link

@marco-carvalho marco-carvalho commented May 15, 2024

Hi @jbogard.

First of all, thank you for creating this lib.

Second, I would like to propose setting the TargetFrameworks solely to netstandard2.0. This change aims to increase the compatibility of the library with a broader range of projects, especially those that are not yet able to upgrade to newer .NET versions.

Changes included:

  • Updated the TargetFrameworks in the project file(s) solely to netstandard2.0.
  • Adjusted any code dependencies or features to ensure compatibility with netstandard2.0.

Benefits:

  • Wider adoption and usability in legacy projects.
  • Greater flexibility for developers working with diverse project setups.

Please let me know if there are any additional concerns or if further modifications are needed.

Looking forward to your feedback.

@marco-carvalho marco-carvalho changed the title Update Respawn.csproj Downgrade to "netstandard2.0" May 15, 2024
@marco-carvalho marco-carvalho force-pushed the patch-1 branch 3 times, most recently from 6766f7c to dc8e780 Compare May 15, 2024 15:37
@marco-carvalho marco-carvalho marked this pull request as ready for review May 15, 2024 15:59
@jbogard
Copy link
Owner

jbogard commented May 17, 2024

The way I want to handle this is to direct users to the last version on netstandard2.0, NOT to downgrade features in the current version. That version would be release 4.0.

@marco-carvalho
Copy link
Author

Hi @jbogard,

Thank you for your prompt response.

I understand your preference for directing users to the last version that supports netstandard2.0, which is release 4.0. However, I would like to clarify that my proposed changes do not involve downgrading features or altering method signatures. The goal is solely to adjust the target framework for broader compatibility, particularly for projects that haven't yet upgraded to newer .NET versions.

The current version, 6.2.1 (released on January 19, 2024), includes numerous changes since version 4.0. By making the library compatible with netstandard2.0, users can benefit from these improvements without needing to upgrade their project's framework.

I believe this approach could provide significant value to developers working in diverse environments while maintaining the integrity of the library's features. Please let me know if there's any aspect of this proposal you'd like to discuss further or if you have any additional concerns.

Looking forward to your feedback.

@jbogard
Copy link
Owner

jbogard commented May 17, 2024

This PR removes a bunch of async/await though. Yes the public API is unaffected but the internal implementation changed. I'm just not interested in supporting .NET Framework indefinitely (or lower frameworks). I'm only targeting really current .NET Core versions with the latest releases.

@marco-carvalho
Copy link
Author

What if it could be something like this?

#if NETSTANDARD2_0
            using var cmd = connection.CreateCommand();
#else
            await using var cmd = connection.CreateCommand();
#endif

@marco-carvalho marco-carvalho changed the title Downgrade to "netstandard2.0" Set TargetFrameworks solely to "netstandard2.0" May 17, 2024
@jbogard
Copy link
Owner

jbogard commented May 20, 2024

That can work I think, let's see how bad it is.

@marco-carvalho marco-carvalho force-pushed the patch-1 branch 3 times, most recently from 5a788d5 to fab7217 Compare May 24, 2024 13:44
@marco-carvalho
Copy link
Author

@jbogard done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants