Skip to content

Commit

Permalink
type information of SMBDirEntryInformation.last_write_time set to dat…
Browse files Browse the repository at this point in the history
…etime (#280)

* SMBDirEntryInformation.last_write_time is datetime now

* SMBDirEntryInformation CHANGELOG

* Update CHANGELOG.md

Co-authored-by: Adi Roiban <[email protected]>

---------

Co-authored-by: Adi Roiban <[email protected]>
  • Loading branch information
christianknoepfle and adiroiban authored Jun 6, 2024
1 parent 3f69e6d commit 2ce49ef
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## 1.14.0 - TBD

* Dropped support for Python 3.7
* `SMBDirEntryInformation.last_write_time` is now annotated as `datetime.datetime`. Previously, it was `datetime.date`. https://github.com/jborean93/smbprotocol/issues/279

## 1.13.0 - 2024-03-21

Expand Down
2 changes: 1 addition & 1 deletion src/smbclient/_os.py
Original file line number Diff line number Diff line change
Expand Up @@ -1187,7 +1187,7 @@ def _set_basic_information(
class SMBDirEntryInformation(t.NamedTuple):
creation_time: datetime.datetime
last_access_time: datetime.datetime
last_write_time: datetime.date
last_write_time: datetime.datetime
change_time: datetime.datetime
end_of_file: int
allocation_size: int
Expand Down

0 comments on commit 2ce49ef

Please sign in to comment.