Skip to content

Commit

Permalink
InfoAdditionalInformation should be of type flags and not enum fixes #…
Browse files Browse the repository at this point in the history
  • Loading branch information
wokis authored Nov 8, 2021
1 parent 2b3403b commit a6c8a2f
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Changelog

## 1.8.3 - TBD

* Set `additional_information` field in `SMB2SetInfoRequest` to a flags field rather than a single enum as per protocol docs


## 1.8.2 - 2021-11-03

* Add missing `FileAttributes` enum values
Expand Down
4 changes: 2 additions & 2 deletions smbprotocol/open.py
Original file line number Diff line number Diff line change
Expand Up @@ -1037,9 +1037,9 @@ def __init__(self):
default=96
)),
('reserved', IntField(size=2)),
('additional_information', EnumField(
('additional_information', FlagField(
size=4,
enum_type=InfoAdditionalInformation,
flag_type=InfoAdditionalInformation,
)),
('file_id', BytesField(size=16)),
('buffer', BytesField(
Expand Down

0 comments on commit a6c8a2f

Please sign in to comment.