[XP3.0] Microprofile default config and FP build #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jfdenise
commented
Mar 30, 2021
jfdenise
commented
- cekit module needed to build XP3.0 galleon feature-pack.
luck3y
previously approved these changes
Mar 30, 2021
jmesnil
reviewed
Apr 8, 2021
|
|
||
| <installation xmlns="urn:jboss:galleon:provisioning:3.0"> | ||
| <!-- Use the image version, to avoid retrieving metadata.xml for un-released s2i FP--> | ||
| <feature-pack location="eap-s2i@maven(org.jboss.universe:s2i-universe)#23.0.0.Final"> |
There was a problem hiding this comment.
We used to use the upstream version. I agree that we could align with product version. This version is not documented, but still.
|
|
||
| <installation xmlns="urn:jboss:galleon:provisioning:3.0"> | ||
| <!-- Use the image version, to avoid retrieving metadata.xml for un-released s2i FP--> | ||
| <feature-pack location="eap-s2i@maven(org.jboss.universe:s2i-universe)#23.0.0.Final"> |
| <modelVersion>4.0.0</modelVersion> | ||
| <groupId>org.jboss.eap.galleon.s2i</groupId> | ||
| <artifactId>eap-s2i-galleon-pack</artifactId> | ||
| <version>23.0.0.Final</version> |
There was a problem hiding this comment.
that answers my question but I'm still confused. Why do we have a EAP artifact that uses a version which seems related to WildFly?
|
@luck3y I changed the FP version to 3.0.0.Final to match product. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.