Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWITCHYARD-2009 #671

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

SWITCHYARD-2009 #671

wants to merge 1 commit into from

Conversation

jorgemoralespou
Copy link

As discussed here: https://community.jboss.org/message/870119.
Also a pull request for core

@kcbabo
Copy link
Member

kcbabo commented Oct 23, 2014

Here's an alternative approach for consideration. I haven't tested it, but there's enough there to get the idea across.

https://github.com/kcbabo/core/tree/SWITCHYARD-2009
https://github.com/kcbabo/components/tree/SWITCHYARD-2009

// Maintain old functionality
if (_config.isPreferLocal()){
if ((_registry != null)
&& (_registry.hasLocalEndpoint(serviceName)) && (_loadBalancer != null)) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain this logic?
If you select preferLocal, no matter if clustered or not this executes (Fine)
then if there is a localEndpoint for the service and load balance strategy do a remote otherwise a local?
I think that it should be something like:

  • if there is localendpoint invokeLocal, otherwise invokeRemote.

Also, now that this is a RemoteInvoker, you could optimize that if the "LoadBalanceStrategy" gets you a local endpoint, invokeLocal.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are making a comment on code I didn't write. :-) This looks to be a comment on the code you initially submitted. At least that's what GitHub is showing me with your comment.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a fucker. Tiredness fooled me.
I'm cool with your changes, in fact, very cool as it will always make local calls if prefer local and service is covered, otherwise it will load balance.

@kcbabo
Copy link
Member

kcbabo commented Oct 23, 2014

I think you clicked on the commit that you submitted as part of the PR. My commit is not associated with a PR at this point other than the link to my branch that I provided above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants