Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JBEAP-20671] Make version string in Mojarra translations controlled … #86

Open
wants to merge 1 commit into
base: 2.3.9.SP
Choose a base branch
from

Conversation

spyrkob
Copy link

@spyrkob spyrkob commented Dec 7, 2020

…by pom.xml

Issue: https://issues.redhat.com/browse/JBEAP-20671

@fjuma this seems to have been changed for 2.3.9.SP01, don't know if you remember the reason? Reverting to this behaviour would let us just change the version in pom on releases

@fjuma
Copy link

fjuma commented Dec 7, 2020

@spyrkob Thanks very much for looking into this! I think I needed to change it because |version.string| wasn't working at the time (the way I checked was by deploying a JSF app to EAP/WildFly and checking if the "Initializing Mojarra..." message showed the right version in the server log). If it is working now though, then we can change it back.

@spyrkob
Copy link
Author

spyrkob commented Dec 7, 2020

With the change I get following:
156 2020-12-07 11:39:44,391 INFO [javax.enterprise.resource.webcontainer.jsf.config] (ServerService Thread Pool -- 76) Initializing Mojarra 2.3.9.SP14-SNAPSHOT for context '/greeter'

A small change would be that the printed version will contain productised name (it will be something like Mojarra 2.3.9.SP14-redhat-00001). AFAIK that's the same way it was displayed in EAP 7.2.

@fjuma
Copy link

fjuma commented Dec 7, 2020

With the change I get following:
156 2020-12-07 11:39:44,391 INFO [javax.enterprise.resource.webcontainer.jsf.config] (ServerService Thread Pool -- 76) Initializing Mojarra 2.3.9.SP14-SNAPSHOT for context '/greeter'

Perfect, that's the same way it was displayed before. Feel free to go ahead and merge this one. Thanks very much @spyrkob!

@spyrkob
Copy link
Author

spyrkob commented Dec 7, 2020

No problem :)
I'll schedule this for next CP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants