Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

send to segment, not google anayltics (JBIDE-28396) #760

Merged
merged 14 commits into from
Jun 22, 2023
Merged

send to segment, not google anayltics (JBIDE-28396) #760

merged 14 commits into from
Jun 22, 2023

Conversation

adietish
Copy link
Member

@adietish adietish commented Jun 8, 2023 •
edited
Loading

@adietish adietish self-assigned this Jun 8, 2023
@adietish adietish force-pushed the JBIDE-28396 branch 7 times, most recently from fb33610 to 4b9d41f Compare June 14, 2023 21:26
@adietish adietish force-pushed the JBIDE-28396 branch 2 times, most recently from ffc2c34 to ff3625e Compare June 15, 2023 13:47
@adietish adietish changed the title copied intellij-telemetry & made it compile (JBIDE-28396) send to telemetry, not google anayltics (JBIDE-28396) Jun 15, 2023
@adietish adietish force-pushed the JBIDE-28396 branch 4 times, most recently from 6b07051 to f360941 Compare June 16, 2023 14:16
@adietish adietish marked this pull request as ready for review June 16, 2023 14:38
@adietish adietish requested a review from sbouchet June 16, 2023 14:38
@adietish adietish marked this pull request as draft June 16, 2023 14:41
@adietish adietish marked this pull request as ready for review June 16, 2023 15:01
sbouchet
sbouchet reviewed Jun 19, 2023
View reviewed changes
Copy link
Contributor

@sbouchet sbouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above remarks

@adietish adietish changed the title send to telemetry, not google anayltics (JBIDE-28396) send to segment, not google anayltics (JBIDE-28396) Jun 19, 2023
@adietish adietish force-pushed the JBIDE-28396 branch 2 times, most recently from b7e5b42 to 9d50a7e Compare June 19, 2023 09:31
sbouchet
sbouchet previously approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@sbouchet sbouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fbricon
Copy link
Member

fbricon commented Jun 20, 2023

Since we're collecting exactly the same data, only changing the processing backend, and everything still abides by the Red Hat privacy statement the users agreed on, we don't need to ask again

fbricon
fbricon requested changes Jun 20, 2023
View reviewed changes
Copy link
Member

@fbricon fbricon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a bunch of new files have 2021 or 2022 in their copyright header. If the code was copied from somewhere else, it'd be nice to link to the original code

...rg.jboss.tools.usage/src/org/jboss/tools/usage/internal/preferences/GlobalUsageSettings.java Outdated Show resolved Hide resolved
...ss.tools.usage/src/org/jboss/tools/usage/internal/reporting/UsageReportEnablementDialog.java Outdated Show resolved Hide resolved
...ugins/org.jboss.tools.usage/src/org/jboss/tools/usage/internal/reporting/messages.properties Outdated Show resolved Hide resolved
...ins/org.jboss.tools.usage/src/org/jboss/tools/usage/internal/telemetry/core/service/IDE.java Outdated Show resolved Hide resolved
...usage/src/org/jboss/tools/usage/internal/telemetry/core/service/TelemetryServiceFactory.java Outdated Show resolved Hide resolved
.../org.jboss.tools.usage/src/org/jboss/tools/usage/internal/telemetry/core/util/FileUtils.java Show resolved Hide resolved
...org.jboss.tools.usage/src/org/jboss/tools/usage/internal/telemetry/core/util/MapBuilder.java Show resolved Hide resolved
.../org.jboss.tools.usage/src/org/jboss/tools/usage/internal/telemetry/core/util/TimeUtils.java Show resolved Hide resolved
usage/plugins/org.jboss.tools.usage/src/org/jboss/tools/usage/telemetry/TelemetrySender.java Show resolved Hide resolved
usage/plugins/org.jboss.tools.usage/src/org/jboss/tools/usage/telemetry/TelemetrySender.java Outdated Show resolved Hide resolved
@adietish adietish mentioned this pull request Jun 21, 2023
Merged
@adietish adietish requested a review from fbricon June 21, 2023 14:22
@adietish
Copy link
Member Author

@fbricon thanks for the inputs. Corrected these, please re-review.

@adietish adietish requested a review from sbouchet June 21, 2023 14:24
sbouchet
sbouchet previously approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@sbouchet sbouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fbricon
Copy link
Member

fbricon commented Jun 22, 2023

@adietish feel free to merge once the small nits are addressed

@adietish
corrected identation & typo
47ff727 
Signed-off-by: Andre Dietisheim <[email protected]>
@adietish adietish requested a review from fbricon June 22, 2023 14:57
@adietish adietish merged commit 66e01f4 into jbosstools:main Jun 22, 2023
@adietish adietish deleted the JBIDE-28396 branch June 22, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbricon fbricon fbricon approved these changes

@sbouchet sbouchet sbouchet left review comments

Assignees

@adietish adietish

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adietish @sbouchet @fbricon