Gatekeeper Guide

1. Check Pull Requests page on GitHub for open requests

Important: Pull requests with dev_ prefix are not ready to merge - developers still work on them. A developer remove the mentioned prefix, when a pull request is ready to merge. Check comments whether no other gatekeeper is working on the pull request.

2. Pick a request you want to merge and add a comment like looking
3. Check appropriate verification job (e.g. jbtis43x.verification.test)

• the job is run after a pull request is created
• the job runs smoke tests of all modules
• the pull request can be merged only if relevant build was successful
• the job can be rerun on a pull request (in case of the request was changed), just comment the request on GitHub with text: retest this please or test this

4. Open terminal and navigate to your local jbosstools-integration-stack-tests repository
5. Execute following commands:

git checkout master

git pull upstream master

git fetch ${developer’s remote}

Important: Before you can do it, ${developer’s remote} must be added. For example:

• git remote add tsedmik [email protected]:tsedmik/jbosstools-integration-stack-tests.git
• git fetch tsedmik

Note: To list all remotes use git remote -v

git checkout ${developer’s remote}/JBTISTEST-${request number}

git checkout -b tmp

git rebase master

Important: If some conflict during rebasing are emerged, reject the pull request and ask creator of the request to solve conflicts first. After that continue from 3.

gitk

Important: Review commits in the pull request. No binary files are allowed. If you need to clarify something, contact creator of the request via conversation on GitHub. Once you are satisfied, proceed with the next command.

git checkout master

git merge tmp

Important: Using gitk ensure that the history of commits is linear

git push origin master

git push upstream master

git branch -D tmp

6. Check the pull request on GitHub. If the status of request is not Merged, comment and close the request with text: pushed to master

---

Questions? Ask apodhrad (Andrej Podhradský) or tsedmik (Tomáš Sedmík) for help.