fix: disks with no bin items cannot be targets (#99)

jbrodriguez · Aug 9, 2024 · cd3d100 · cd3d100
1 parent 67b6417
commit cd3d100
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/ui/src/flows/gather/transfer/target.tsx b/ui/src/flows/gather/transfer/target.tsx
@@ -42,7 +42,9 @@ export const Target: React.FunctionComponent = () => {
   }
 
   // if no bin then this disk isn't elegible as a target
-  const elegible = disks.filter((disk) => plan.vdisks[disk.path].bin);
+  const elegible = disks.filter(
+    (disk) => plan.vdisks[disk.path].bin && plan.vdisks[disk.path].bin.items,
+  );
 
   // sort elegible disks by least amount of data transfer
   const targets = elegible.sort((a, b) => {

diff --git a/ui/src/shared/bin/bin.tsx b/ui/src/shared/bin/bin.tsx
@@ -26,7 +26,7 @@ export const Bin: React.FunctionComponent<BinProps> = ({ disk = '' }) => {
 
   const bin = plan.vdisks[disk].bin;
 
-  if (!bin) {
+  if (!bin || !bin.items) {
     return (
       <div className="h-full bg-neutral-100 dark:bg-gray-950">
         <div className="flex flex-col p-2">