Fixed "double-dot" extensions in output bin directory #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
related with issue #22 |
|
Not sure why the CI build is failing. It doesn't seem to have anything to do with my changes. Something about a mutex?
|
|
👍 on the fix. I need the CI build to work before I can merge though. Ultimately, the CI build artifact nuget packages are what gets released on nuget.org. Looks like the build is failing on the MSVC standard library patches. Not sure what is up with that. Unfortunately i don't have time time to debug this at the moment. If you can figure out what is going on i would gladly except your fix as part of this pull request. In the past i found the best way to debug this kind of thing is to actually login to the appveyor build worker. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you install the NuGet package in a project and build, all the Mapnik files will be copied to the output bin directory. However all the files in the
mapnikandsharedirectories will have an extra dot in their names:This change should fix that.
Sorry, I wasn't able to actually test my changes because I don't have .NET 4.5.2 specifically installed on my development machine. But I've done a similar thing for a separate project and I'm pretty sure this should fix the issue.