Skip to content

Commit

Permalink
(#171) Add puzzle for junit migration
Browse files Browse the repository at this point in the history
  • Loading branch information
andreoss committed Jun 25, 2020
1 parent 7f97d11 commit b76b7f4
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,15 @@ OF THE POSSIBILITY OF SUCH DAMAGE.
<optional>true</optional>
</dependency>
<dependency>
<!--
@todo #171:30m Migrate all simple tests to Junit 5. For the sake of
smaller PRs, migration can be done in steps
1) All tests classes without @Rule, and @Test(expected = ...)
2) All parameterized tests classes
3) The rest, (i.e dependent on @Rule's and so on)
After completing one of the steps, create a new puzzle for the next.
After all tests are run by Junit 5 remove this dependency.
-->
<groupId>org.junit.vintage</groupId>
<artifactId>junit-vintage-engine</artifactId>
<version>${junit-platform.version}</version>
Expand Down

2 comments on commit b76b7f4

@0pdd
Copy link

@0pdd 0pdd commented on b76b7f4 Jun 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puzzle 171-f8bc6a22 discovered in pom.xml and submitted as #194. Please, remember that the puzzle was not necessarily added in this particular commit. Maybe it was added earlier, but we discovered it only now.

@0pdd
Copy link

@0pdd 0pdd commented on b76b7f4 Jun 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puzzle 171-01da2b80 discovered in pom.xml and submitted as #195. Please, remember that the puzzle was not necessarily added in this particular commit. Maybe it was added earlier, but we discovered it only now.

Please sign in to comment.