Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove the loop condition in the test code to fix CI #3

Merged
merged 8 commits into from
Aug 8, 2023

Conversation

ShingmoYeung
Copy link
Contributor

@ShingmoYeung ShingmoYeung commented Aug 8, 2023

Remove the loop condition in the test code.

Fix: #2

[NEW] Added WatcherConstant.java
[NEW] Added LettuceRedisWatcher.java
[NEW] Added LettuceSubscriber.java
[NEW] Added LettuceSubThread.java
[NEW] Added LettuceRedisWatcherTest.java
[UPDATE] Updated .gitignore
[NEW] Added .releaserc.json
[NEW] Added maven-settings.xml
[NEW] Added pom.xml
[UPDATE] Updated README.md
@casbin-bot
Copy link

@tangyang9464 @imp2002 please review

@hsluoyz
Copy link
Member

hsluoyz commented Aug 8, 2023

@ShingmoYeung plz fix conflicts

image

@ShingmoYeung
Copy link
Contributor Author

@ShingmoYeung plz fix conflicts

image

@hsluoyz permission denied?

image
image

@hsluoyz
Copy link
Member

hsluoyz commented Aug 8, 2023

@ShingmoYeung it's your PR. You of course have rights to modify it. If you cannot do it by web, you can modify your commits in git

# Conflicts:
#	src/test/java/org/casbin/test/LettuceRedisWatcherTest.java
…uster.

- Add Redis URI constants.
- Update Redis connection initialization in LettuceRedisWatcher.
- Add constructors for different Redis connection types.
- Add support for Redis Cluster in LettuceRedisWatcher.
- Update LettuceRedisWatcherTest to test Redis Cluster connection.
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@178bebf). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head a1f16af differs from pull request most recent head 01ea04d. Consider uploading reports for the commit 01ea04d to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master       #3   +/-   ##
=========================================
  Coverage          ?   82.08%           
=========================================
  Files             ?        4           
  Lines             ?      134           
  Branches          ?       11           
=========================================
  Hits              ?      110           
  Misses            ?       17           
  Partials          ?        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ShingmoYeung
Copy link
Contributor Author

@ShingmoYeung it's your PR. You of course have rights to modify it. If you cannot do it by web, you can modify your commits in git

@hsluoyz fixed it, code-review please

@hsluoyz
Copy link
Member

hsluoyz commented Aug 8, 2023

@ShingmoYeung plz fix:

image

@hsluoyz hsluoyz changed the title [bug]: Remove the loop condition in the test code fix: Remove the loop condition in the test code to fix CI Aug 8, 2023
@hsluoyz hsluoyz merged commit bef8318 into jcasbin:master Aug 8, 2023
1 check passed
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: the build CI test cannot stop
3 participants