Followup to review comment: etcdctl checks for min > max.

Signed-off-by: Cristian Ferretti <[email protected]>
jcferretti · Jul 2, 2024 · 90db063 · 90db063
1 parent e1872c7
commit 90db063
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/etcdctl/ctlv3/command/get_command.go b/etcdctl/ctlv3/command/get_command.go
@@ -197,6 +197,11 @@ func getGetOp(args []string) (string, []clientv3.OpOption) {
 	}
 
 	if getMaxCreateRev > 0 {
+                if getMinCreateRev > getMaxCreateRev {
+                        cobrautl.ExitWithError(cobrautl.ExitBadFeature,
+                              fmt.Errorf("getMinCreateRev(=%v) > getMaxCreateRev(=%v)", getMinCreateRev, getMaxCreateRev))
+
+                }
 		opts = append(opts, clientv3.WithMaxCreateRev(getMaxCreateRev))
 	}
 
@@ -205,6 +210,10 @@ func getGetOp(args []string) (string, []clientv3.OpOption) {
 	}
 
 	if getMaxModRev > 0 {
+                if getMinModRev > getMaxModRev {
+                        cobrautl.ExitWithError(cobrautl.ExitBadFeature,
+                              fmt.Errorf("getMinModRev(=%v) > getMaxModRev(=%v)", getMinModRev, getMaxModRev))
+                }
 		opts = append(opts, clientv3.WithMaxModRev(getMaxModRev))
 	}