This repository has been archived by the owner on Sep 24, 2018. It is now read-only.
Template creation feature and file creation changes #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've been thinking about this and like it. I think we would need to add a Edit Template feature too. |
added 3 commits
October 17, 2016 16:40
Added description to templates
Changed vscode opening to use node process spawning
jchannon
reviewed
Oct 18, 2016
| import * as path from 'path'; | ||
| import * as vscode from 'vscode'; | ||
|
|
||
| export class TemplateManager { |
There was a problem hiding this comment.
What do you have against classes? or is it that I called it 'Manager' ?
There was a problem hiding this comment.
Naming is hard, what do you suggest?
jchannon
suggested changes
Oct 18, 2016
| @@ -0,0 +1,12 @@ | |||
| { | |||
There was a problem hiding this comment.
is tslint something that needs to go in package.json
There was a problem hiding this comment.
I suppose it should be bought in as a dev dependency, but for now, I was just installing it globally.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings around 2 features.
Firstly, I have removed the
New C# classandNew C# Interfaceoptions, in favour ofNew C# Filewhich will then prompt the user from a drop down to select which template they want to use.This dropdown menu pulls information in from the template file (using${Description: test description here}to show the template name and a description (See image below).To implement this, the files are iterated in the template directory, and a promise is returned to generate the
QuickPickItemwhich has the information for our templates. Because we are using promises, vs code will show us a loading bar in the quick pick menu if for some reason it takes a while to load.Secondly, I have added a second command, to create a new template file. Once executed, this command prompts the user to input a template name, this template file is then created and the templates folder is opened in a new window of vs code, allowing the user to edit and save the new template, and use it immediately.
I haven't yet found a way to open the template file after creating the new vs code instance to edit the template, as soon as I find that, I will implement it.
Feel free to tell me this isn't how you wanted it to work, and I can re-work this as needed :)