Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pp_ast ppxlib to this repo #1

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

pedrobslisboa
Copy link
Collaborator

@pedrobslisboa pedrobslisboa commented Dec 9, 2024

Description

The major issue with maintaining this repo is that the AST tree can change over time. For example, nowadays, the astexplorer with ocaml and reason is outdated.

As ppxlib provided a builtin way to print the ast tree we can now keep the astexplorer always updated with the new tree

Warning

For now I'm pinning ppxlib as we still not have the pp_ast on a version and the json feature is under review: ocaml-ppx/ppxlib#526

Testing on astexplorer

  • Clone the astexplorer repo: https://github.com/pedrobslisboa/astexplorer/
  • Checkout to this branch: feat/update-refmt
  • In website folder of astexplorer, call yarn link <path-to-astexplorer-refmt>.

Screenshots

Before:
Captura de Tela 2024-12-11 às 16 17 47

After:
Captura de Tela 2024-12-11 às 16 16 10

@pedrobslisboa
Copy link
Collaborator Author

Btw, I need to update the README

Copy link
Owner

@jchavarri jchavarri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much! I think the readme should be updated to reflect these changes. Edit: oh, i just saw your comment 😅

dune-project Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@pedrobslisboa
Copy link
Collaborator Author

@jchavarri README updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants