-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pp_ast ppxlib to this repo #1
Open
pedrobslisboa
wants to merge
4
commits into
jchavarri:master
Choose a base branch
from
pedrobslisboa:feat/pp_ast_ppxlib
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Btw, I need to update the README |
jchavarri
reviewed
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much! I think the readme should be updated to reflect these changes. Edit: oh, i just saw your comment 😅
pedrobslisboa
force-pushed
the
feat/pp_ast_ppxlib
branch
from
December 11, 2024 01:04
29a6cc4
to
f8881f4
Compare
@jchavarri README updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The major issue with maintaining this repo is that the AST tree can change over time. For example, nowadays, the astexplorer with ocaml and reason is outdated.
As ppxlib provided a builtin way to print the ast tree we can now keep the astexplorer always updated with the new tree
Warning
For now I'm pinning ppxlib as we still not have the pp_ast on a version and the json feature is under review: ocaml-ppx/ppxlib#526
Testing on astexplorer
https://github.com/pedrobslisboa/astexplorer/
feat/update-refmt
website
folder ofastexplorer
, callyarn link <path-to-astexplorer-refmt>
.Screenshots
Before:
After: