Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove requestjs #37

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Remove requestjs #37

wants to merge 8 commits into from

Conversation

martinkooij
Copy link

Hi,

  • I removed the dependency on the deprecated "request.js" module in favor of "node-fetch".
  • I rewrote the fetcher towards using async/await; at the same time solving the existing issue of the module at times firing too many requests within a short time period to google when multiple destinations were specified (*).

Feel free to merge.
Martin

(*) Note: basically the existing foreach created a number of callbackfunctions that all fired to Google one after the other. With Debian and node.js now more efficient and my internet better at home it caused the Google API to protest. By using the async await in a loop, we wait for the answer first before going to the next request.

@martinkooij martinkooij mentioned this pull request Jul 2, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@martinkooij