This repository has been archived by the owner on Mar 25, 2018. It is now read-only.
cloudstack: adding support for create volume from a custom disk offering #1464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adrian Cole » jclouds #1144 SUCCESS |
|
I followed the method naming convention in the existing code. It would be nice to tidy up some of this code to use shorter method names like we do in the newer modules, but the ongoing maintenance would be hard (e.g. changing the XClient#getX() calls to XApi#get() would require either deprecating most of the methods or, more likely, an entirely new module). |
|
Adrian Cole » jclouds #1164 SUCCESS |
|
jclouds-java-7-pull-requests #318 SUCCESS |
|
+1 |
codefromthecrypt
pushed a commit
that referenced
this pull request
Apr 4, 2013
cloudstack: adding support for create volume from a custom disk offering
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing issue #1463