This repository has been archived by the owner on Nov 29, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add configurable StagedPhysicsPlugin #171
feat: add configurable StagedPhysicsPlugin #171
Changes from 5 commits
d386400
e6234f7
757fab9
96e5415
aa33af3
3481bac
8ff4b9f
b78ac9b
2605f41
10b5dff
8d75717
9cf50fc
c2766ab
8f24617
47e248a
2283b59
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe this approach will work for something like
bevy_ggrs
(yet). That libraryimpl Stage for GGRSStage
, which it uses to handle updating game state withggrs
, which it adds beforeCoreStage::Update
. Unfortunately,add_system_set_to_stage
only works for SystemStages. This means, specifically forbevy_ggrs
at least, that bevy function will not find theGGRSStage
and add the desired step systems.That's not to say this PR doesn't work, just that it will not work with other plugins that implement custom stages (i.e.,
bevy_ggrs
). (I am guessingbevy_backroll
also falls into this category, but I have not read much, going by thisimpl Stage
)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. Not sure if we even can do anything for it until stageless.