Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed boolean reading #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixed boolean reading #65

wants to merge 1 commit into from

Conversation

apesti
Copy link

@apesti apesti commented Apr 4, 2018

Couldn't read booleans because they were set to 0 in the thrift file which would then evaluate to False when checking their truth value. Changed it so it specifically checks whether the type is None.

@jcrobak
Copy link
Owner

jcrobak commented Apr 4, 2018

thanks for the fix - do you happen to have a simple test case that we can add?

I'll look into why the CI build failed; it seems unrelated.

@apesti
Copy link
Author

apesti commented Apr 4, 2018

Sorry I don't have one and I couldn't figure out how to make one for this but any small parquet file with booleans should work as a test case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants