Publish JavaScript modules (ESM) #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Language Services can understand these map files, and use them to map declaration-file based definition locations to their original source, when available.
TypeScript needs the `types` (with node10 module resolution) or `export.types` (with node16 module resolution) to be defined in order for declarations to actually be picked up, otherwise the following error would be emitted: > Cannot find module 'shortcut-buttons-flatpickr' or > its corresponding type declarations.
ESM module are published unminified by convention. Therefore they can simply be build by `tsc`. We target ES6 for now to comply with the browser level that flatpickr itself supports. See flatpickr/flatpickr#2468 for more information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESM module are published unminified by convention.
Therefore they can simply be build by
tsc.Also the TypeScript declaration files are linked via package.json now. TypeScript needs the
types(with node10 module resolution) orexports.types(with node16 module resolution) to be defined in order for declarations to actually be picked up, otherwise the following error would be emitted:Additionally declaration mappings are published so Language Services can understand these map files and use them to map declaration-file based definition locations to their original source, when available.
See https://www.typescriptlang.org/docs/handbook/release-notes/typescript-2-9.html#new---declarationmap