Shell scripts unix line endings #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…out with UNIX line endings (LF). Otherwise, when cloning the repo and running `ant install` on a Windows system, the ascsh and ascshd scripts have Windows line endings (CRLF), and are unusable if run with e.g. Cygwin.
Otherwise semicolon was treated as end of statement, and shell tried to execute compiler.jar.
…forward slashes in path to ascsh. When running on Windows, AIR_SDK_HOME might contain backslashes, causing a problem with the `IO.popen` call. Ensuring forward slashes fixes the issue.
Works with Cygwin/ruby.
|
The branch name is not entirely appropriate anymore, I should have made two separate PRs. |
|
I've been travelling, I'll check this out in the next couple of days. Thanks! |
|
Nice, whenever you have time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added gitattributes - use mostly auto CRLF mode, but force LF for shell scripts (.sh files and ascsh) in particular. UNIX shell can't handle CRLF in scripts, Ruby seems to be ok so I didn't force LF for ascshd.
Second change is a fix - ascsh script didn't work due to a typo -
:in java classpath option, should be;.