Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing up the Type exports for all the distributed libraries #795

Merged
merged 24 commits into from
Jul 8, 2020

Conversation

jdalrymple
Copy link
Owner

@jdalrymple jdalrymple commented May 15, 2020

Ensures all types are exported properly. This includes all the services, groups, schemas etc

fixes #793

📦 Published PR as canary version: 23.0.1-canary.795.164270378.0

✨ Test out this PR locally via:

npm install @gitbeaker/[email protected]
npm install @gitbeaker/[email protected]
npm install @gitbeaker/[email protected]
npm install @gitbeaker/[email protected]
npm install @gitbeaker/[email protected]
# or 
yarn add @gitbeaker/[email protected]
yarn add @gitbeaker/[email protected]
yarn add @gitbeaker/[email protected]
yarn add @gitbeaker/[email protected]
yarn add @gitbeaker/[email protected]

@jdalrymple jdalrymple added the bug label May 15, 2020
@jdalrymple jdalrymple force-pushed the 793-review-typing branch from b0946cd to a4351fc Compare May 17, 2020 16:15
@jdalrymple
Copy link
Owner Author

Could someone quickly check this branch to see if the types are exported correctly. Im not sure if my issues are from my local

@jdalrymple
Copy link
Owner Author

I almost got this working, just need to solve this last piece. I posted on stackoverflow, but if you guys have any ideas, hmu :D

@sdc224
Copy link

sdc224 commented May 24, 2020

Could someone quickly check this branch to see if the types are exported correctly. Im not sure if my issues are from my local

Sure will check it out. By the way when we are expecting to get it updated in packages?

@jdalrymple
Copy link
Owner Author

Could someone quickly check this branch to see if the types are exported correctly. Im not sure if my issues are from my local

Sure will check it out. By the way when we are expecting to get it updated in packages?

I think i JUST broke it lol so hold off for a minute hehe. As soon as i get some guidance on the stackoverflow post, this will be finally tested and merged :)

@sdc224
Copy link

sdc224 commented May 24, 2020

Hehe no problem man 😄

@jdalrymple jdalrymple added release:canary Deploy canary release and removed Help Wanted labels May 31, 2020
@jdalrymple jdalrymple force-pushed the 793-review-typing branch from 011b713 to d047b2e Compare May 31, 2020 13:48
@jdalrymple
Copy link
Owner Author

jdalrymple commented May 31, 2020

This is odd, although the .d.ts file is being generated correctly, its still returning "any" as the type:

Here is a snippet index.d.ts.

import * as Gitbeaker from '@gitbeaker/core';
export declare const a: typeof Gitbeaker.Groups;
export declare const Groups: typeof Gitbeaker.Groups, GroupAccessRequests: typeof Gitbeaker.GroupAccessRequests;

but when i import it into another library like:

import { Projects } from '@gitbeaker/node';

It still shows Projects:any :/

This can be seen in the latest canary version: 19.7.1-canary.795.151344891.0

@sdc224 Feel free to give it a look. Maybe im doing something wrong :s

@jdalrymple
Copy link
Owner Author

😢 The cli tests are failing randomly with a Error 502 Bad Gateway from Git lab. -_-

@jdalrymple jdalrymple force-pushed the 793-review-typing branch from 52c5655 to b6b2401 Compare June 7, 2020 23:47
@jdalrymple
Copy link
Owner Author

@sdc224 Fixed up the canary build. Give it a look if you have a moment to see if the types are being exported for you!

@jdalrymple
Copy link
Owner Author

Looks to be working now!

@jdalrymple jdalrymple merged commit c10dba3 into master Jul 8, 2020
@jdalrymple jdalrymple deleted the 793-review-typing branch July 8, 2020 09:45
@jdalrymple
Copy link
Owner Author

🚀 PR was released in 23.1.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:canary Deploy canary release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review Typing support of the gitbeaker distributions
2 participants