-
-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing up the Type exports for all the distributed libraries #795
Conversation
b0946cd
to
a4351fc
Compare
Could someone quickly check this branch to see if the types are exported correctly. Im not sure if my issues are from my local |
I almost got this working, just need to solve this last piece. I posted on stackoverflow, but if you guys have any ideas, hmu :D |
Sure will check it out. By the way when we are expecting to get it updated in packages? |
I think i JUST broke it lol so hold off for a minute hehe. As soon as i get some guidance on the stackoverflow post, this will be finally tested and merged :) |
Hehe no problem man 😄 |
011b713
to
d047b2e
Compare
This is odd, although the .d.ts file is being generated correctly, its still returning "any" as the type: Here is a snippet index.d.ts.
but when i import it into another library like:
It still shows Projects:any :/ This can be seen in the latest canary version: 19.7.1-canary.795.151344891.0 @sdc224 Feel free to give it a look. Maybe im doing something wrong :s |
😢 The cli tests are failing randomly with a Error 502 Bad Gateway from Git lab. -_- |
52c5655
to
b6b2401
Compare
@sdc224 Fixed up the canary build. Give it a look if you have a moment to see if the types are being exported for you! |
b729883
to
4fee152
Compare
Looks to be working now! |
🚀 PR was released in |
Ensures all types are exported properly. This includes all the services, groups, schemas etc
fixes #793
📦 Published PR as canary version:
23.0.1-canary.795.164270378.0
✨ Test out this PR locally via: