feat(plugin): add focus tracker plugin #139
Conversation
|
CLA signature looks good 👍 |
|
If you're in agreement with the approach, I'll add tests and move this to |
ericrallen
force-pushed
the
feature/focus-tracker
branch
from
467bd28
to
1bb3eba
Compare
|
I haven't forgotten this. I will try to make time this week to give feedback. Thank you for your patience. |
|
Have you see then the new Accessibility Insights for Web extension that Microsoft has created? It has a great tab tracker in it. I like the lines it draws between elements (though I think I want an arrow pointing in the forward direction). How difficult do you think it would be to add this kind of feature to this work? |
There was a problem hiding this comment.
This looks great. I have some requests inline and an overall one based on the tab tracking in the Accessibility Insights version of this feature. I'd love to hear your thoughts on this.
Also, this needs rebasing onto the latest master since we've now got proper prod vs dev builds going on (no more build artifacts in the repo!).
Great work!
plugins/focus-tracker/index.js
Outdated
| } | ||
|
|
||
| getDescription() { | ||
| return "Keep track of what's been focused as you tab through the page"; |
There was a problem hiding this comment.
No work requested; just musing. I wonder if we can add i18n support to tota11y at some point to make it even more useful for folks.
There was a problem hiding this comment.
I think you definitely could. It might be nice to create an Issue to track moving all the strings like this into JSON (you could probably do one Strings file per plugin) so it's easier to translate and select which language you'd like to load the relevant strings for.
|
@somewhatabstract I just looked at the plugin you mentioned. It shouldn't be too hard to implement something similar. I do have some concerns about the way they continue to increment the tab count if you move back and forth between items, though. I feel like you end up with more noise than signal once the numbers start to lose a coherent pattern:
|
Yes, I agree. I think if we reach something we already saw, we should keep the number it had (and perhaps make it clear that we looped back to the "start"). What do you think? |
|
I also think it isn't clear exactly what the number refers to, so I think some level of connection between the number and the tabbed content makes sense (which is more akin to how we annotate in tota11y anyway). |
ericrallen
force-pushed
the
feature/focus-tracker
branch
from
483d4b9
to
018a295
Compare
|
@somewhatabstract @ericrallen Hey folks, is it still in progress? Let me know if I can help somehow. Really neat feature to have for this tool! |
Hi there, @ohazda, thanks for your encouragement and inquiry :) The delay has been my fault. Unfortunately, priorities what they are, I have not had the bandwidth to tend to this particular garden. In the meantime, if you need focus tracking for accessibility testing, I can recommend the Accessibility Insights extension (https://chrome.google.com/webstore/detail/accessibility-insights-fo/pbjjkligggfmakdaogkfomddhfmpjeni). |
|
@somewhatabstract I see, it's ok. Thanks for the update. I've tried that one but personally I love that tota11y can be integrated into codebase. |
Thank you for your understanding. This is useful feedback. |
I took a stab at adding a Focus Tracker so that users can see what elements have received focus while navigating with a keyboard.
I wasn't sure exactly what styles you'd want to indicate it, but I think this works pretty well.
I left this in Draft Mode because of the tweaks I made to the
InfoPanel. It was just so large to only be displaying the current status that we wereTracking Focus, so I added an option that will make it stay fairly small and out of the way.Also, given the few mentions I've seen of refactoring away from jQuery, I went ahead and made this Plugin have no dependencies.
Closes #127