Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(calendar): add viewmode #2985
base: next
Are you sure you want to change the base?
feat(calendar): add viewmode #2985
Changes from 18 commits
d4a51a0
99c272b
635f37b
eb12eda
831fb9e
19f7397
ca536a4
0b781ef
4a0f2f2
6715bdc
2fb671a
403c7fb
348672a
119688b
8e8a72d
04ed29a
0fdd3e7
14b86d8
d8a0a6c
52a73d2
ae32866
a1c2ee8
3c320d6
f2491db
94d65a2
5968bc8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
需要修正 children 属性的传递方式
直接通过 prop 传递 children 不符合 React 的最佳实践。
建议修改如下:
Also applies to: 172-173
🧰 Tools
🪛 Biome (1.9.4)
[error] 153-153: Avoid passing children using a prop
The canonical way to pass children in React is to use JSX elements
(lint/correctness/noChildrenProp)