This repository has been archived by the owner on Nov 30, 2023. It is now read-only.
Bugfix: Allow simultaneously adding cards and browsing cards #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the bug where simultaneous adding new cards and having the card browser open for editing stops the auto-fill feature from working correctly. `edit.EditManager` wrongly assumes that there is only one `Editor` instance. The window for adding cards and the browsing window each instantiate their own editor.
|
Much appreciated. I'm very likely to merge this once I've resolved the more critical issues and had some time to test the changes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where simultaneous adding new cards and having the card browser open for editing stops the auto-fill feature from working correctly.
edit.EditManagerwrongly assumes that there is only oneEditorinstance. The window for adding cards and the browsing window each instantiate their own editor.Other small changes include replacing some legacy GUI hooks, see