Improvements to eliminate deprecated API usages and the logged warnings for them #216
Conversation
| @@ -75,24 +75,24 @@ def load_menu(): | |||
| ) | |||
|
|
|||
| add_menu('Chinese::Bulk Fill') | |||
| add_menu_item('Chinese::Bulk Fill', _('Hanzi'), bulk_fill_hanzi) | |||
There was a problem hiding this comment.
For these removals of the usage of _(), please note this change in Anki
You will see that the function does nothing, and simply triggers a print to stdout to warn about its deprecation, so the removal should have no effect.
| @@ -10,7 +10,7 @@ | |||
|
|
|||
| import re | |||
| from anki import hooks | |||
| from anki.utils import stripHTML | |||
| from anki.utils import strip_html as stripHTML | |||
There was a problem hiding this comment.
Good work on tackling the deprecations!
I suggest here to use the default provided by the ankitects (strip_html) and change the function calls inside the code accordingly.
It's best not to confuse and another dev might think: Why, there is a deprecation let's fix it... ah, they just kept the old name, figures.
By the way. Could it be that @luoliyan or @joeminicucci need more collaborators to check the PRs and all? I would volunteer having been using this addon for a long time and also am collaborating to other Anki addons (namely https://github.com/zjosua/anki-mc/issues, which is much simpler admittedly 🙂).
When debugging this add on for #215 I noticed that there is a lot of output about deprecated APIs. I made these changes to address those warnings.