Add missing @OverRide annotations

git-svn-id: http://google-refine.googlecode.com/svn/trunk@2171 7d457c2a-affb-35e4-300a-418c747d4874
jdunck · Aug 2, 2011 · 9b335a5 · 9b335a5
1 parent 76076fe
commit 9b335a5
Show file tree

Hide file tree

Showing 246 changed files with 631 additions and 15 deletions.
diff --git a/README.txt b/README.txt
@@ -52,8 +52,14 @@ This is the full list of contributors (in chronological order):
  - Iain Sproat <[email protected]>
  - Tom Morris <[email protected]>
  - Heather Campbell <[email protected]>
-
-
+ - Thad Guidry <[email protected]>
+ - Paul Makepeace <[email protected]>
+ - Tomaž Šolc <[email protected]>
+ - Gabriel Sjoberg <[email protected]>
+ - Rod Salazar <[email protected]>
+ - pxb <[email protected]>
+
+ We welcome additional contributors if you'd like to help out.
                                 - o -
 
 

diff --git a/extensions/freebase/src/com/google/refine/freebase/FreebaseTopic.java b/extensions/freebase/src/com/google/refine/freebase/FreebaseTopic.java
@@ -49,6 +49,7 @@ public FreebaseTopic(String id, String name) {
         this.name = name;
     }
 
+    @Override
     public void write(JSONWriter writer, Properties options)
             throws JSONException {
 

diff --git a/extensions/freebase/src/com/google/refine/freebase/FreebaseType.java b/extensions/freebase/src/com/google/refine/freebase/FreebaseType.java
@@ -46,6 +46,7 @@ public FreebaseType(String id, String name) {
         super(id, name);
     }
 
+    @Override
     public void write(JSONWriter writer, Properties options)
         throws JSONException {
 

diff --git a/extensions/freebase/src/com/google/refine/freebase/ProtographTransposeExporter.java b/extensions/freebase/src/com/google/refine/freebase/ProtographTransposeExporter.java
@@ -54,6 +54,7 @@ public ProtographTransposeExporter(String contentType) {
 		_contentType = contentType;
 	}
 
+    @Override
     public String getContentType() {
         return "application/x-unknown";
     }
@@ -67,6 +68,7 @@ public void export(Project project, Properties options, Engine engine,
         throw new RuntimeException("Not implemented");
     }
 
+    @Override
     public void export(Project project, Properties options, Engine engine,
             Writer writer) throws IOException {
 

diff --git a/...ions/freebase/src/com/google/refine/freebase/commands/auth/CheckAuthorizationCommand.java b/...ions/freebase/src/com/google/refine/freebase/commands/auth/CheckAuthorizationCommand.java
@@ -52,6 +52,7 @@ public class CheckAuthorizationCommand extends Command {
 
     final static Logger logger = LoggerFactory.getLogger("check-authorization_command");
 
+    @Override
     public void doGet(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException {
 
         try {

diff --git a/extensions/freebase/src/com/google/refine/freebase/expr/MqlKeyQuote.java b/extensions/freebase/src/com/google/refine/freebase/expr/MqlKeyQuote.java
@@ -53,6 +53,7 @@ public class MqlKeyQuote implements Function {
     final static private Pattern fullValidKeyPattern = Pattern.compile(fullValidKey);
     final static private Pattern keyCharMustQuotePattern = Pattern.compile(keyCharMustQuote);
 
+    @Override
     public Object call(Properties bindings, Object[] args) {
         if (args.length == 1) {
             Object o1 = args[0];
@@ -63,6 +64,7 @@ public Object call(Properties bindings, Object[] args) {
         return null;
     }
 
+    @Override
     public void write(JSONWriter writer, Properties options)
         throws JSONException {
 

diff --git a/extensions/freebase/src/com/google/refine/freebase/expr/MqlKeyUnquote.java b/extensions/freebase/src/com/google/refine/freebase/expr/MqlKeyUnquote.java
@@ -45,6 +45,7 @@ SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 public class MqlKeyUnquote implements Function {
     final static private Pattern quotedCharPattern = Pattern.compile("\\$([0-9A-Fa-f]{4})");
 
+    @Override
     public Object call(Properties bindings, Object[] args) {
         if (args.length == 1) {
             Object o1 = args[0];
@@ -75,6 +76,7 @@ public Object call(Properties bindings, Object[] args) {
         return null;
     }
 
+    @Override
     public void write(JSONWriter writer, Properties options)
         throws JSONException {
 

diff --git a/extensions/freebase/src/com/google/refine/freebase/model/changes/DataExtensionChange.java b/extensions/freebase/src/com/google/refine/freebase/model/changes/DataExtensionChange.java
@@ -126,6 +126,7 @@ protected DataExtensionChange(
         _newRows = newRows;
     }
 
+    @Override
     public void apply(Project project) {
         synchronized (project) {
             if (_firstNewCellIndex < 0) {
@@ -257,6 +258,7 @@ protected void extendRow(
         }
     }
 
+    @Override
     public void revert(Project project) {
         synchronized (project) {
             project.rows.clear();
@@ -270,6 +272,7 @@ public void revert(Project project) {
         }
     }
 
+    @Override
     public void save(Writer writer, Properties options) throws IOException {
         writer.write("baseColumnName="); writer.write(_baseColumnName); writer.write('\n');
         writer.write("columnInsertIndex="); writer.write(Integer.toString(_columnInsertIndex)); writer.write('\n');

diff --git a/extensions/freebase/src/com/google/refine/freebase/model/recon/DataExtensionReconConfig.java b/extensions/freebase/src/com/google/refine/freebase/model/recon/DataExtensionReconConfig.java
@@ -80,6 +80,7 @@ public int getBatchSize() {
         throw new RuntimeException(WARN);
     }
 
+    @Override
     public void write(JSONWriter writer, Properties options) throws JSONException {
         writer.object();
         writer.key("mode"); writer.value("extend");

diff --git a/extensions/freebase/src/com/google/refine/freebase/model/recon/GuidBasedReconConfig.java b/extensions/freebase/src/com/google/refine/freebase/model/recon/GuidBasedReconConfig.java
@@ -69,6 +69,7 @@ public GuidBasedReconConfig() {
     static protected class GuidBasedReconJob extends ReconJob {
         String guid;
 
+        @Override
         public int getKey() {
             return guid.hashCode();
         }
@@ -102,6 +103,7 @@ public String getBriefDescription(Project project, String columnName) {
         return "Reconcile cells in column " + columnName + " as Freebase IDs";
     }
 
+    @Override
     public void write(JSONWriter writer, Properties options)
             throws JSONException {
 

diff --git a/extensions/freebase/src/com/google/refine/freebase/model/recon/IdBasedReconConfig.java b/extensions/freebase/src/com/google/refine/freebase/model/recon/IdBasedReconConfig.java
@@ -69,6 +69,7 @@ public IdBasedReconConfig() {
     static protected class IdBasedReconJob extends ReconJob {
         String id;
 
+        @Override
         public int getKey() {
             return id.hashCode();
         }
@@ -106,6 +107,7 @@ public String getBriefDescription(Project project, String columnName) {
         return "Reconcile cells in column " + columnName + " as Freebase IDs";
     }
 
+    @Override
     public void write(JSONWriter writer, Properties options)
             throws JSONException {
 

diff --git a/extensions/freebase/src/com/google/refine/freebase/model/recon/KeyBasedReconConfig.java b/extensions/freebase/src/com/google/refine/freebase/model/recon/KeyBasedReconConfig.java
@@ -80,6 +80,7 @@ public KeyBasedReconConfig(FreebaseTopic namespace) {
     static protected class KeyBasedReconJob extends ReconJob {
         String key;
 
+        @Override
         public int getKey() {
             return key.hashCode();
         }
@@ -106,6 +107,7 @@ public String getBriefDescription(Project project, String columnName) {
         return "Reconcile cells in column " + columnName + " to topics with keys in namespace " + namespace.id;
     }
 
+    @Override
     public void write(JSONWriter writer, Properties options)
             throws JSONException {
 

diff --git a/extensions/freebase/src/com/google/refine/freebase/oauth/FreebaseProvider.java b/extensions/freebase/src/com/google/refine/freebase/oauth/FreebaseProvider.java
@@ -50,14 +50,17 @@ public FreebaseProvider(String host) {
         super(host);
     }
 
+    @Override
     public String getRequestTokenServiceURL() {
         return "https://" + host + "/api/oauth/request_token";
     }
 
+    @Override
     public String getAccessTokenServiceURL() {
         return "https://" + host + "/api/oauth/access_token";
     }
 
+    @Override
     public String getUserAuthorizationURL() {
         return "https://" + host + "/signin/app";
     }

diff --git a/...s/freebase/src/com/google/refine/freebase/oauth/FreebaseTimeCommonsHttpOAuthConsumer.java b/...s/freebase/src/com/google/refine/freebase/oauth/FreebaseTimeCommonsHttpOAuthConsumer.java
@@ -72,6 +72,7 @@ public FreebaseTimeCommonsHttpOAuthConsumer(String consumerKey, String consumerS
      * NOTE: this call is potentially vulnerable to a man-in-the-middle (MITM) attack, but the same
      * could be said if we used an NTP client.
      */
+    @Override
     protected String generateTimestamp() {
 
         long time = -1;

diff --git a/extensions/freebase/src/com/google/refine/freebase/operations/ExtendDataOperation.java b/extensions/freebase/src/com/google/refine/freebase/operations/ExtendDataOperation.java
@@ -96,6 +96,7 @@ public ExtendDataOperation(
         _columnInsertIndex = columnInsertIndex;
     }
 
+    @Override
     public void write(JSONWriter writer, Properties options)
             throws JSONException {
 
@@ -109,6 +110,7 @@ public void write(JSONWriter writer, Properties options)
         writer.endObject();
     }
 
+    @Override
     protected String getBriefDescription(Project project) {
         return "Extend data at index " + _columnInsertIndex + 
             " based on column " + _baseColumnName;
@@ -120,6 +122,7 @@ protected String createDescription(Column column, List<CellAtRow> cellsAtRows) {
             " by filling " + cellsAtRows.size();
     }
 
+    @Override
     public Process createProcess(Project project, Properties options) throws Exception {
         return new ExtendDataProcess(
             project, 
@@ -148,6 +151,7 @@ public ExtendDataProcess(
             _job = new FreebaseDataExtensionJob(_extension);
         }
 
+        @Override
         public void write(JSONWriter writer, Properties options)
                 throws JSONException {
 
@@ -160,6 +164,7 @@ public void write(JSONWriter writer, Properties options)
             writer.endObject();
         }
 
+        @Override
         protected Runnable getRunnable() {
             return this;
         }
@@ -194,6 +199,7 @@ public void end(Project project) {
                 	// nothing to do
                 }
 
+                @Override
                 public boolean visit(Project project, int rowIndex, Row row) {
                     Cell cell = row.getCell(_cellIndex);
                     if (cell != null && cell.recon != null && cell.recon.match != null) {
@@ -246,6 +252,7 @@ protected int extendRows(
             return end;
         }
 
+        @Override
         public void run() {
             List<Integer> rowIndices = new ArrayList<Integer>();
             List<DataExtension> dataExtensions = new ArrayList<DataExtension>();

diff --git a/extensions/freebase/src/com/google/refine/freebase/operations/ImportQADataOperation.java b/extensions/freebase/src/com/google/refine/freebase/operations/ImportQADataOperation.java
@@ -64,6 +64,7 @@ static public AbstractOperation reconstruct(Project project, JSONObject obj) thr
     public ImportQADataOperation() {
     }
 
+    @Override
     public void write(JSONWriter writer, Properties options)
             throws JSONException {
 

diff --git a/extensions/freebase/src/com/google/refine/freebase/operations/SaveProtographOperation.java b/extensions/freebase/src/com/google/refine/freebase/operations/SaveProtographOperation.java
@@ -64,6 +64,7 @@ public SaveProtographOperation(Protograph protograph) {
         _protograph = protograph;
     }
 
+    @Override
     public void write(JSONWriter writer, Properties options)
         throws JSONException {
 
@@ -74,6 +75,7 @@ public void write(JSONWriter writer, Properties options)
         writer.endObject();
     }
 
+    @Override
     protected String getBriefDescription(Project project) {
         return "Save schema alignment skeleton";
     }
@@ -93,6 +95,7 @@ public ProtographChange(Protograph protograph) {
             _newProtograph = protograph;
         }
 
+        @Override
         public void apply(Project project) {
             synchronized (project) {
                 _oldProtograph = (Protograph) project.overlayModels.get("freebaseProtograph");
@@ -101,6 +104,7 @@ public void apply(Project project) {
             }
         }
 
+        @Override
         public void revert(Project project) {
             synchronized (project) {
                 if (_oldProtograph == null) {
@@ -111,6 +115,7 @@ public void revert(Project project) {
             }
         }
 
+        @Override
         public void save(Writer writer, Properties options) throws IOException {
             writer.write("newProtograph="); writeProtograph(_newProtograph, writer); writer.write('\n');
             writer.write("oldProtograph="); writeProtograph(_oldProtograph, writer); writer.write('\n');

diff --git a/extensions/freebase/src/com/google/refine/freebase/protograph/AnonymousNode.java b/extensions/freebase/src/com/google/refine/freebase/protograph/AnonymousNode.java
@@ -50,6 +50,7 @@ public AnonymousNode(FreebaseType type) {
         this.type = type;
     }
 
+    @Override
     public void write(JSONWriter writer, Properties options)
             throws JSONException {
 
@@ -66,14 +67,17 @@ public void write(JSONWriter writer, Properties options)
         writer.endObject();
     }
 
+    @Override
     public void addLink(Link link) {
         links.add(link);
     }
 
+    @Override
     public Link getLink(int index) {
         return links.get(index);
     }
 
+    @Override
     public int getLinkCount() {
         return links.size();
     }

diff --git a/extensions/freebase/src/com/google/refine/freebase/protograph/CellKeyNode.java b/extensions/freebase/src/com/google/refine/freebase/protograph/CellKeyNode.java
@@ -49,6 +49,7 @@ public CellKeyNode(
         this.namespace = namespace;
     }
 
+    @Override
     public void write(JSONWriter writer, Properties options)
         throws JSONException {
 

diff --git a/extensions/freebase/src/com/google/refine/freebase/protograph/CellTopicNode.java b/extensions/freebase/src/com/google/refine/freebase/protograph/CellTopicNode.java
@@ -52,6 +52,7 @@ public CellTopicNode(
         this.type = type;
     }
 
+    @Override
     public void write(JSONWriter writer, Properties options)
         throws JSONException {
 
@@ -77,14 +78,17 @@ public void write(JSONWriter writer, Properties options)
         writer.endObject();
     }
 
+    @Override
     public void addLink(Link link) {
         links.add(link);
     }
 
+    @Override
     public Link getLink(int index) {
         return links.get(index);
     }
 
+    @Override
     public int getLinkCount() {
         return links.size();
     }

diff --git a/extensions/freebase/src/com/google/refine/freebase/protograph/CellValueNode.java b/extensions/freebase/src/com/google/refine/freebase/protograph/CellValueNode.java
@@ -50,6 +50,7 @@ public CellValueNode(
         this.lang = lang;
     }
 
+    @Override
     public void write(JSONWriter writer, Properties options)
         throws JSONException {
 

diff --git a/extensions/freebase/src/com/google/refine/freebase/protograph/FreebaseTopicNode.java b/extensions/freebase/src/com/google/refine/freebase/protograph/FreebaseTopicNode.java
@@ -50,6 +50,7 @@ public FreebaseTopicNode(FreebaseTopic topic) {
         this.topic = topic;
     }
 
+    @Override
     public void write(JSONWriter writer, Properties options)
             throws JSONException {
 
@@ -67,14 +68,17 @@ public void write(JSONWriter writer, Properties options)
         writer.endObject();
     }
 
+    @Override
     public void addLink(Link link) {
         links.add(link);
     }
 
+    @Override
     public Link getLink(int index) {
         return links.get(index);
     }
 
+    @Override
     public int getLinkCount() {
         return links.size();
     }
-Original file line number
+Diff line change
@@ Expand Up / @@ -52,6 +52,7 @@ public class CheckAuthorizationCommand extends Command { @@
         final static Logger logger = LoggerFactory.getLogger("check-authorization_command");
+        @Override
         public void doGet(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException {
             try {
@@ Expand Down @@