Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: quit interactive menus with single-key shortcut escape #64

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

roele
Copy link
Collaborator

@roele roele commented Dec 8, 2024

To not break any API contracts in terms of compatibility, throwing an error of type io::ErrorKind::Interrupted is probably the best option when cancelling the input.

Docs and examples also need to be updated to reflect this.

@roele roele force-pushed the issues/62 branch 4 times, most recently from 7d31ed2 to 3599064 Compare December 8, 2024 17:19
@jdx jdx linked an issue Dec 8, 2024 that may be closed by this pull request
@roele roele force-pushed the issues/62 branch 2 times, most recently from 386a8ed to a529c24 Compare December 9, 2024 07:20
@roele roele marked this pull request as ready for review December 9, 2024 16:39
@roele roele requested a review from jdx December 9, 2024 16:39
@jdx jdx merged commit 7787af8 into jdx:main Dec 9, 2024
1 of 2 checks passed
@roele roele deleted the issues/62 branch December 9, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quit interactive menus with single-key shortcuts: escape, q, c
2 participants