Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: migrate tests from unit to e2e #3231

Merged
merged 2 commits into from
Nov 27, 2024
Merged

test: migrate tests from unit to e2e #3231

merged 2 commits into from
Nov 27, 2024

Conversation

jdx
Copy link
Owner

@jdx jdx commented Nov 27, 2024

these are covered by e2e tests (at least well enough for now) and I want to remove unit tests that modify file state. One reason for this is I basically need it to work on windows.

Copy link

github-actions bot commented Nov 27, 2024

Hyperfine Performance

mise x -- echo

Command Mean [ms] Min [ms] Max [ms] Relative
mise-main x -- echo 19.2 ± 0.6 18.0 21.3 1.01 ± 0.04
mise-2024.11.30 x -- echo 19.1 ± 0.6 17.9 22.5 1.00
mise x -- echo 19.3 ± 0.7 17.9 26.4 1.01 ± 0.05

mise env

Command Mean [ms] Min [ms] Max [ms] Relative
mise-main env 15.6 ± 0.6 14.5 18.7 1.01 ± 0.05
mise-2024.11.30 env 15.5 ± 0.5 14.4 17.0 1.00
mise env 15.7 ± 0.5 14.6 17.3 1.02 ± 0.05

mise hook-env

Command Mean [ms] Min [ms] Max [ms] Relative
mise-main hook-env 15.6 ± 0.6 14.5 18.6 1.00
mise-2024.11.30 hook-env 15.7 ± 0.8 14.4 21.7 1.01 ± 0.06
mise hook-env 15.6 ± 0.6 14.5 17.8 1.00 ± 0.05

mise ls

Command Mean [ms] Min [ms] Max [ms] Relative
mise-main ls 13.1 ± 0.3 12.5 17.1 1.02 ± 0.04
mise-2024.11.30 ls 12.8 ± 0.3 12.1 14.8 1.00
mise ls 13.1 ± 0.3 12.6 14.5 1.03 ± 0.04

Copy link

codacy-production bot commented Nov 27, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-29.41% 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (f246584) 22401 17147 76.55%
Head commit (bcf14e3) 42622 (+20221) 20089 (+2942) 47.13% (-29.41%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3231) 45 45 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@jdx jdx force-pushed the e2e-tests branch 3 times, most recently from 2743022 to 0a614a6 Compare November 27, 2024 13:57
@jdx jdx merged commit a530e44 into main Nov 27, 2024
24 checks passed
@jdx jdx deleted the e2e-tests branch November 27, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant