Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add edge color #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Frou-HOS
Copy link

@Frou-HOS Frou-HOS commented Feb 8, 2018

For choose Edges color

@kefniark
Copy link

Nice feature 👍

About the code there are few indentation issue (space vs tabs)

@kefniark
Copy link

kefniark commented May 11, 2018

Hum, I think there is a small issue with this PR.
This color setting works only only with 2 modes (Triangle depth & Roberts Cross)
image

The three other mode (Sobel & Triangle luminance) are unchanged
image

FragD & VertLum probably also require some modification

@jean-moreno
Copy link
Owner

Thanks for this!
I haven't looked into it in depth yet, but I'd like this repository to keep being the exact copy of the legacy image effect from Unity.

Not sure how to go about making a version with extended features on GitHub - should I make it a separate branch, or make a new repo that could be linked to this one somehow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants