Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified unsupported conntent donwload. #265

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Modified unsupported conntent donwload. #265

wants to merge 1 commit into from

Conversation

S03D4-164
Copy link

Fixed some download problem:

  • Page loaded
    • page_loaded signal would be sent before the loading of the resources is finished. Need some sleep after the page has been loaded.
  • Unsupported content download
    • Default reply.readyRead causes duplicate reading of reply, so it should be disconnected.
      Also, reply.data should be cleared.
    • _reply_download_content creates a resource when readyRead, this causes spliting one content to multiple resources.

@EvaSDK EvaSDK mentioned this pull request Dec 22, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@S03D4-164