Introduce RemoteIndexClient #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jay Deng <[email protected]>
owenhalpert
force-pushed
the
ohalpert-remote-vector-dev
branch
3 times, most recently
from
47db2b4 to
d7e9ce3
Compare
Add RemoteIndexClient initial implementation, its accompanying dependencies, and Build Request, Retry Strategy, and test files Signed-off-by: owenhalpert <[email protected]>
owenhalpert
force-pushed
the
ohalpert-remote-vector-dev
branch
from
d7e9ce3 to
84ba0ca
Compare
jed326
reviewed
Feb 25, 2025
src/main/java/org/opensearch/knn/index/codec/nativeindex/remote/RemoteIndexBuildStrategy.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/knn/index/codec/nativeindex/remote/RemoteIndexBuildStrategy.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/knn/index/codec/nativeindex/remote/RemoteIndexBuildStrategy.java
Show resolved
Hide resolved
| * @return The HTTP Client | ||
| */ | ||
| private CloseableHttpClient createHttpClient() { | ||
| // TODO The client will need to be rebuilt iff we decide to allow for retry configuration in the future |
There was a problem hiding this comment.
Let's clearly delineate what is going in the first cut vs what is going in future work. You can use opensearch-project#2464 for future work.
| * @return job_id from the server response used to track the job | ||
| */ | ||
| public String submitVectorBuild(RemoteBuildRequest request) throws IOException { | ||
| URI endpoint = URI.create(KNNSettings.state().getSettingValue(KNNSettings.KNN_REMOTE_BUILD_SERVICE_ENDPOINT)); |
There was a problem hiding this comment.
We need to have validation on the settings, and we should also add this to shouldBuildIndexRemotely
src/main/java/org/opensearch/knn/index/remote/RemoteIndexClient.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/knn/index/remote/RemoteIndexClient.java
Outdated
Show resolved
Hide resolved
| * InterruptedExceptions will cause a fallback to local CPU build. | ||
| */ | ||
| @Log4j2 | ||
| public class RemoteIndexClient { |
There was a problem hiding this comment.
I wonder if we need an interface here to support extending to other client types, for example if we want to support not polling in the future or gRPC or anything else. It may make testing easier too.
src/main/java/org/opensearch/knn/index/remote/RemoteIndexClientRetryStrategy.java
Outdated
Show resolved
Hide resolved
jed326
force-pushed
the
remote-vector-dev
branch
from
4b9e282 to
97ff4b7
Compare
Access modifiers, small refactoring variable names and constants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First PR for opensearch-project#2518 (Client Skeleton, Build Request, Error Handling, Unit Tests)
This PR introduces the initial implementation of the Remote Index client, which is awaiting implementation on the following:
Related Issues
opensearch-project#2391 Meta Issue
opensearch-project#2393 HLD by @jed326
opensearch-project#2518 My LLD
Check List
- [ ] New functionality has been documented.- [ ] API changes companion pull request created.--signoff.- [ ] Public documentation issue/PR created.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.