-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes in FindPetsc and related modules from Flow123d #3
base: master
Are you sure you want to change the base?
Conversation
Just get all Jed's modules. Conflicts: LICENSE
FindPETSc - add support for extracting more variables from PETSc mekefiles - succed with warning if tests compiles but do not run ( e.g. on PBS systems) - more informative error messages FindPackageMultipass - add MULTIPASS_C_SOURCE_COMPILES ResolveCompilerPaths - add comments with changes possibly necessary on cygwin (needs more testing)
CorrectWindowsPaths.cmake - do not convert paths under cygwin ResolveCompilerPaths.cmake - make beter lib name separation for libraries given by absolute path CMake's find_library needs the root part of the filename (i.e. .../lib(ROOT).a)
# PETSC_COMPILER - Compiler used by PETSc, helpful to find a compatible MPI | ||
# PETSC_DEFINITIONS - Compiler switches for using PETSc | ||
# PETSC_MPIEXEC - Executable for running MPI programs | ||
# PETSC_VERSION - Version string (MAJOR.MINOR.SUBMINOR) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why these whitespace changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for these and other unnecessary changes in whitespace.
On 09/05/2013 06:19 PM, Jed Brown wrote:
Once done this will define
-# PETSC_FOUND - system has PETSc
-# PETSC_INCLUDES - the PETSc include directories
-# PETSC_LIBRARIES - Link these to use PETSc
-# PETSC_COMPILER - Compiler used by PETSc, helpful to find a compatible MPI
-# PETSC_DEFINITIONS - Compiler switches for using PETSc
-# PETSC_MPIEXEC - Executable for running MPI programs
-# PETSC_VERSION - Version string (MAJOR.MINOR.SUBMINOR)
+# PETSC_FOUND - system has PETSc
+# PETSC_INCLUDES - the PETSc include directories
+# PETSC_LIBRARIES - Link these to use PETSc
+# PETSC_COMPILER - Compiler used by PETSc, helpful to find a compatible MPI
+# PETSC_DEFINITIONS - Compiler switches for using PETSc
+# PETSC_MPIEXEC - Executable for running MPI programs
+# PETSC_VERSION - Version string (MAJOR.MINOR.SUBMINOR)Why these whitespace changes?
Reply to this email directly or view it on GitHub:
https://github.com/jedbrown/cmake-modules/pull/3/files#r6186106
Mgr. Jan Brezina, Ph. D.
Technical University in Liberec, New technologies institute
http://www.nti.tul.cz/cz/WikiUser:Jan.Brezina
Remove unecessary changes in formating, add parameter PETSC_EXPORT_LIST leave Debian hint path
Conflicts: FindPETSc.cmake
Conflicts: FindPETSc.cmake FindPackageMultipass.cmake
First, this is my first serious use of git, github and pull request. Sorry for any inconveniences.