-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple cpu mem build export #641
base: master
Are you sure you want to change the base?
Decouple cpu mem build export #641
Conversation
I like the idea yet it gets tricky with Gentoo since |
@vaskas I agree with you, we would have to handle that before the export. Recreate make.conf with the right amount of cpu just before the export. Like in the reboot script : https://github.com/jedi4ever/veewee/blob/master/templates/gentoo-latest-i686-experimental/reboot.sh |
There are two values that get set within make.conf with nr_cpus MAKEOPTS and EMERGE_DEFAULT_OPTS Neither one is end of the world terrible at the current level on the smaller box exported. MAKEOPTS="-j$((1 + $nr_cpus)) -l$nr_cpus.5" from the make man page: EMERGE_DEFAULT_OPTS="-j$nr_cpus --quiet-build=y" There is a cleanup.sh script run right before the zerodisk.sh script and this is where I would put the change to the make.conf values. I'll push an update to this pull request that does this. |
Thanks @davidmmiller, sounds great! Also, If you are looking at the current template, I created a pull request that fixes it (#674). |
👍 Thanks to you both :) |
hey, is this PR still valid? if it is could you rebase it on current master so it could be merged? |
Valid? Yes. |
ok then, can you please rebase on master, there were to many changes preventing simple merge and I would prefer not to loos anything in manual merge. |
This change will allow decoupling the cpu and memory settings during box build/install and the final exported box.