Add a basic support for automatic table of content generation #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to a macro-like syntax: <<toc>> I added a toc_test methods to TestCreole2htmlMarkup to perform unittest. I pached the existing tests so that they are correct despite the modification I made. It supports: - max depth: depth=NUMBER - links to the correct section
|
Thanks for contributing. Looks good to me, if the points above are fixed, i will merge. |
- Avoid use of float('inf')
- Rename python_list2html_list to toc_list2html (more coherent)
- Rename variables in toc_list2html to be clearer
- Use document.replace('<p><<toc>></p>', html_toc, 1) in toc emit to limit replacement
Unit tests still fail in python2 (but pass with python3).
|
I address (normally) all your comment (except unit tests) with bcdd5e9. |
|
Still fails according to Travis with the following error: I am not able to reproduce on my computer, all tests pass (python 3.3 on Fedora 20). And the syntax seems correct. Any idea ? |
|
remove u before '' ?!? |
|
I can try. But normally this syntax is correct in both python3 and 2. |
jedie
added a commit
that referenced
this pull request
May 12, 2014
Add a basic support for automatic table of content generation
|
Thanks for merging! |
|
I will look at it tomorrow and create a new release. Thanks for contributing ;) |
|
I have made some changes arount the |
|
btw. travis will fail, because i used stuff from python 2.7... Does anyone need 2.6 support?!? EDIT: Have commit some changes for 2.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It uses a macro-like syntax: <> to allow code reuse.
I added a toc_test methods to TestCreole2htmlMarkup to perform unittest. I pached the
existing tests so that they are correct despite the modification I made.
It supports: