Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(convert): fix missing slides in HTML presentation after #508 #515

Merged
merged 5 commits into from
Jan 15, 2025

Conversation

Rapsssito
Copy link
Contributor

@Rapsssito Rapsssito commented Jan 14, 2025

Description

Fixes a problem introduced by #508 where lazy loaded slides by RevealJS are never loaded.

Check List

Check all the applicable boxes:

  • I understand that my contributions needs to pass the checks;
  • If I created new functions / methods, I documented them and add type hints;
  • If I modified already existing code, I updated the documentation accordingly;
  • The title of my pull request is a short description of the requested changes.

@Rapsssito
Copy link
Contributor Author

@jeertmans, sorry for the multiple PRs. The minimal example I used to test #508 did not have enough slides so I was not able to discover this bug until now.

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.56%. Comparing base (bf512f2) to head (8134132).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #515   +/-   ##
=======================================
  Coverage   79.56%   79.56%           
=======================================
  Files          23       23           
  Lines        1962     1962           
=======================================
  Hits         1561     1561           
  Misses        401      401           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeertmans
Copy link
Owner

jeertmans commented Jan 14, 2025

Hi @Rapsssito, thanks for your contribution! Could you provide the MWE, so I can at least see the problem before merging this?

@jeertmans jeertmans linked an issue Jan 14, 2025 that may be closed by this pull request
4 tasks
@Rapsssito
Copy link
Contributor Author

@jeertmans, yes, sorry. You can test it with any presentation that is more than 5 slides long.

@jeertmans
Copy link
Owner

Oh my bad, I forgot the --one-file too. I can confirm this fixes the issue you mentioned!

I just have a suggestion for the CHANGELOG entry, otherwise it looks all good to me :-)

CHANGELOG.md Outdated Show resolved Hide resolved
@jeertmans
Copy link
Owner

Thanks!

@jeertmans jeertmans merged commit a58ff6c into jeertmans:main Jan 15, 2025
38 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Convert to HTML works for one scene, but does not work for multiple scenes
2 participants