-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support --save-pk
in demo_video_x.py
#170
base: main
Are you sure you want to change the base?
Conversation
Thank you for this additional work, especially since the existing commented code in demo_video_x.py was left commented out and buggy. While your changes indeed generate the pickle file, using your changes to the blender add on only has a single frame from the generated dance video when choosing male or female, and when choosing "Simplx Neutral", it imports nothing. Perhaps I am missing something? |
Did you download the Smplx Neutral then select 'Smplx Neutral' before importing the pickle? @alevonian |
Hi Orenwang, Nope, that didn't work either. |
Does this make it clearer?
You need to use the fbx format model, same as the female and male models used by the original add-on provided in this repo. |
Yes, that is what I figured, but I have to find smplx-neutral.fbx somewhere. :) |
Just download it in the SMPLX page. Due to licensing, no one can distribute it directly. |
I think I found it in the Unity zip. |
Hah, ok, it is working now. It took like 3 minutes for Blender to finish processing the pickle file, but it worked. |
The bones are incorrectly oriented and the model jumps all over the place, so there may be additional settings to correct for that, but at least it animates. |
Hi, there~ Nice work! I use your code and run well. But there is a problem about fingers. The last joint of every finger will up after extract bvh in blender. Can you check out this issue? Thanks! |
Thanks for your work on implementing / putting back .pkl export for HybrIK-X! I've finally been able to get something useful out of it, it's amazing. :) I'm grateful for the updated Blender addon files as well. Now, when comparing HybrIK-X's raw output and the imported .pkl in Blender, the hands seem to suffer quite a bit... Do you have any idea why? The fingers are hooked and distorded, which is a pity because you can still discern the captured hand poses underneath. So yeah, any help or clue regarding a way to fix this would be awesome. |
@BobHop it's hard to tell what goes wrong without more info. Maybe some screenshots, or reproducible files? |
Indeed. Sorry for the lack of info. Besides, I found a way to correct it!
Having read the previous comments in this discussion, initially I took the smpl-neutral.fbx file from SMPL-X's Unity package; the result is what you see in picture number 3. Later on, I had a look at SMPL-X's Blender Add-on because it features FBX export. So I tried... In an empty scene in Blender, using SMPL-X's addon (the '300 shape components' version) I added the SMPLX_NEUTRAL model and exported it as an .fbx, overwriting the one in the data folder of HybrIK-X's addon. I then tried another import of the same .pk animation and got what you seen in picture number 4. Fingers fixed!! The hand poses aren't perfect, of course – but they're identical to the HybrIK-X raw output, so I guess that's the best fidelity we can get using this project. To me, it's still one of the best methods because HybrIK-X requires only one camera, uses less VRAM yet is rather fast, can work with cropped bodies to some extent... You don't get as much accuracy as other methods, especially for the hands, but it's really ok for simple animation needs. |
PS : Oddly, the "Export FBX" button in SMPL-X's Blender add-on produces an .fbx file that doesn't fix the hands (i.e. by clicking the "Update Joint Locations", which is how I obtained result number 4). But using Blender's export to FBX, does produce a "better" .fbx for that matter. The SMPL-X add-on offers some options I didn't try though: I exported "for Unity" but there's also a "for Unreal" choice; maybe this would give different results. |
Currently the implementation of
--save-pk
is missing (and incorrectly named as "--save-pt") indemo_video_x.py
.This PR adds this implementation and outputs a
res.pk
file similar todemo_video.py
.However, if anyone wants to import the pickle file into Blender, you will have to replace files in the original add-on with these hybrik_blender_addon_modified_files that I modified for SMPLX models (make sure to choose "Smplx Neutral" as your model before importing the pickle file).